Update DND sensor icon based on state #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dynamic icons to DND sensor
|
Not sure I agree with this change as modern Android versions use DND as on/off (switching between priority_only and off) and doesn't change the icon. The icons you're using sort of resemble ringer mode, which may be different. |
jpelgrom
changed the title
|
Would it make sense then to clump all DND modes together using single icon for "on" and another for "off"? |
|
If there must be an icon change yes, but as said I don't think the icon should be changed as the system doesn't change icons depending on on/off. |
|
At least in my version of android, no, the icon itself doesn't change but the background changes as a visual indication. |
dshokouhi
reviewed
Jul 16, 2024
common/src/main/java/io/homeassistant/companion/android/common/sensors/DNDSensorManager.kt
Outdated
Show resolved
Hide resolved
…/sensors/DNDSensorManager.kt Co-authored-by: Daniel Shokouhi <[email protected]>
dshokouhi
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding icons based on DND sensor state. Makes for easier visual aid.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes